----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57929/#review170098 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/type_utils.hpp Lines 325 (patched) <https://reviews.apache.org/r/57929/#comment242890> Move this after L348 to be consistent with the ordering of other functions? - Anand Mazumdar On March 25, 2017, 4:30 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57929/ > ----------------------------------------------------------- > > (Updated March 25, 2017, 4:30 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6999 > https://issues.apache.org/jira/browse/MESOS-6999 > > > Repository: mesos > > > Description > ------- > > This patch adds an `operator<<` overload for the `Secret::Type` > protobuf enum to facilitate logging. > > > Diffs > ----- > > include/mesos/type_utils.hpp 19f34a7d8bfa373ca6c51a2061942f709dffb846 > include/mesos/v1/mesos.hpp 0fecc4a971cc28de28c5cec5226cce6231c7682f > src/common/type_utils.cpp 3ab2dc1a27d7e0f97e0f37df2608ccec06f5936b > src/v1/mesos.cpp b21e1e77a816386b03bd378a36992d70c4971fcc > > > Diff: https://reviews.apache.org/r/57929/diff/1/ > > > Testing > ------- > > Testing details can be found at the end of this chain. > > > Thanks, > > Greg Mann > >
