> On March 28, 2017, 12:57 a.m., Benjamin Mahler wrote: > > Approach looks good, just curious if we can avoid more summarized resources > > in favor of a direct translation to json.
On second thought, I suppose this is ok given this is how the role resources are being represented. We just want to be careful to make sure that callers know that this model is a summary (doesn't include the full resources right now). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57767/#review170246 ----------------------------------------------------------- On March 23, 2017, 8:03 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57767/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 8:03 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler. > > > Bugs: MESOS-6995 > https://issues.apache.org/jira/browse/MESOS-6995 > > > Repository: mesos > > > Description > ------- > > Added quota to /roles endpoint of master. > > > Diffs > ----- > > src/common/http.hpp a3cfc5d8f0b2e453d5f6c3e485e92dbd643737a3 > src/common/http.cpp ce32ff36ee58b19f2cb11d80e69ab1ff007e75ef > src/master/http.cpp 862b68ff2e8846d6fb968556a6612ec7dab2a61a > > > Diff: https://reviews.apache.org/r/57767/diff/2/ > > > Testing > ------- > > see next review in this chain > > > Thanks, > > Jay Guo > >
