----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58015/#review170359 -----------------------------------------------------------
Patch looks great! Reviews applied: [58011, 58012, 58013, 58014, 58015] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 29, 2017, 1 a.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58015/ > ----------------------------------------------------------- > > (Updated March 29, 2017, 1 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-7226 > https://issues.apache.org/jira/browse/MESOS-7226 > > > Repository: mesos > > > Description > ------- > > Add name to contributors.yaml file for first contribution. > > > Diffs > ----- > > docs/contributors.yaml 725f50c3d781b187dc61039e84fdd4ada6d874fa > > > Diff: https://reviews.apache.org/r/58015/diff/1/ > > > Testing > ------- > > ## CentOS 7 > > Full build with all changes, made sure build was successful with no errors. > > ## Windows > > Full build with all changes, made sure build was successful with no errors. > > > ## Timing improvements with this change > > #### Build times on Windows (no PCH): > 1. Full build time (everything including 3rd party products): 24:49.47 > (1489.47s total) > 2. Time to rebuild all of Mesos itself: 21:8.63 (1268.63s total) > 3. Time for a build with no changes: 0:30.47 (30.47s total) > 4. Modified file 3rdparty/stout/include/stout/os/os.hpp (added a comment) > 5. Time for an incremental build: 36:55.55 (2215.55s total) > (Very odd that an incremental takes longer than a full build!) > 6. Time for an incremental build (just mesos-agent): 0:14:24.73 (864.73s > total) > 7. Time for an incremental build, mesos-agent only: 0:16:42.57 (1002.57s > total) > (Includes speedup to linker flags) > > > #### Build times on Windows (with PCH): > 1. Full build time (everything including 3rd party products): 19:54.49 > (1194.49s total) > 2. Time to rebuild all of Mesos itself: 0:15:49.58 (949.58s total) > 3. Time for a build with no changes: 0:0:21.72 (21.72s total) > 4. Modified file 3rdparty/stout/include/stout/os/os.hpp (added a comment) > 5. Time for an incremental build: 0:34:40.64 (2080.64s total) > 6. Time for an incremental build (just mesos-agent): 0:11:53.57 (713.57s > total) > 7. Time for an incremental build, mesos-agent only: 0:10:43.10 (643.10s > total) > (Includes speedup to linker flags) > > > Thanks, > > Jeff Coffler > >
