----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58014/#review170445 -----------------------------------------------------------
Fix it, then Ship it! Only minor issues, so I'll tweak them before testing and committing. cmake/CompilationConfigure.cmake Lines 32 (patched) <https://reviews.apache.org/r/58014/#comment243270> You need to surround `WIN32` with `${}`. Otherwise, this will default to `OFF` on Windows. You probably didn't catch this because CMake caches options. If you call `cmake .. -DENABLE_PRECOMPILED_HEADERS=1` in the past, then all future builds will use PCHs. The default values for options only take effect if you delete the `CMakeCache.txt` file. cmake/CompilationConfigure.cmake Lines 34-36 (patched) <https://reviews.apache.org/r/58014/#comment243268> I think we can remove this check, as it would block people that want to fix the compilation issues on non-Windows + PCHs. For now, a WARNING should be sufficient. cmake/CompilationConfigure.cmake Lines 39-40 (patched) <https://reviews.apache.org/r/58014/#comment243269> I'll add a comment explaining unity builds: ``` # By default Cotire generates both precompiled headers and a "unity" build. # A unity build is where all the source files in a target are combined into # a single source file to reduce the number of files that need to be opened # and read. We disable "unity" builds for now. ``` - Joseph Wu On March 28, 2017, 5:56 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58014/ > ----------------------------------------------------------- > > (Updated March 28, 2017, 5:56 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-7226 > https://issues.apache.org/jira/browse/MESOS-7226 > > > Repository: mesos > > > Description > ------- > > This sets several cotire variables in the 'src' directory to enable > pre-compiled headers for the 'mesos-agent' target. The excluded > headers were removed due to namespace issues or breaking incremental > builds. > > All cotire variables are conditionally set if option > ENABLE_PRECOMPILED_HEADERS is set. In this commit, this is ON for > WIN32 builds, off for all others. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 5936be07557395ad08b06aa376b5a29f9b11c143 > src/CMakeLists.txt b67b512cafd90558abf712a872310ab913fa38ae > > > Diff: https://reviews.apache.org/r/58014/diff/1/ > > > Testing > ------- > > Testing done at end of chain > > > Thanks, > > Jeff Coffler > >
