----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58012/#review170455 -----------------------------------------------------------
Ship it! Ship It! - Andrew Schwartzmeyer On March 29, 2017, 12:54 a.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58012/ > ----------------------------------------------------------- > > (Updated March 29, 2017, 12:54 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-7226 > https://issues.apache.org/jira/browse/MESOS-7226 > > > Repository: mesos > > > Description > ------- > > Precompiled headers often include new include files that were not > otherwise included in a module. If two include files have the same > class name (with different scopoing), this causes a conflict. > > Fully qualify class names and fix other code issues to allow for > precompiled headers on Windows. > > > Diffs > ----- > > src/internal/evolve.cpp 5ef23067c3f03c7972e24968d4a84b3cf61726a0 > src/slave/containerizer/docker.cpp dfab26224e8679b493d770657f83c711a1d442ef > src/slave/windows_ctrlhandler.hpp 25b14a446175cd302d1840b1f542989ef8315018 > > > Diff: https://reviews.apache.org/r/58012/diff/1/ > > > Testing > ------- > > Testing done at end of chain > > > Thanks, > > Jeff Coffler > >
