> On March 29, 2017, 9 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/windows/os.hpp > > Lines 781 (patched) > > <https://reviews.apache.org/r/56364/diff/4/?file=1677262#file1677262line793> > > > > This comment is a tiny bit too long (> 80 characters).
Ah I really need to get VS Code to highlight lines longer than 80 char for me (and use our clang format rules, and highlight syntax on the fly... so much). - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56364/#review170447 ----------------------------------------------------------- On March 27, 2017, 10:43 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56364/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 10:43 p.m.) > > > Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park. > > > Bugs: MESOS-6892 > https://issues.apache.org/jira/browse/MESOS-6892 > > > Repository: mesos > > > Description > ------- > > `os::create_job` now returns a `Try<SharedHandle>` instead of a raw > `HANDLE`, forcing ownership of the job object handle onto the caller > of the function. `create_job` requires a `std::string name` for the > job object, which is mapped from a PID using `os::name_job`. > > The assignment of a process to the job object is now done via > `Try<Nothing> os::assign_job(SharedHandle, pid_t)`. > > The equivalent of killing a process tree with job object semantics > is simply to terminate the job object. This is done via > `os::kill_job(SharedHandle)`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/windows/os.hpp > 0bedb2d63f5b36afdac2b5a29986f38be96b7c16 > > > Diff: https://reviews.apache.org/r/56364/diff/4/ > > > Testing > ------- > > Testing done at end of chain. > > > Thanks, > > Andrew Schwartzmeyer > >
