> On March 29, 2017, 9:09 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/killtree.hpp > > Lines 41 (patched) > > <https://reviews.apache.org/r/56367/diff/2/?file=1677263#file1677263line42> > > > > A little note on Error conventions: > > > > We generally construct error messages like: > > ``` > > return Error("Failed to determine job object name: " + name.error()); > > ``` > > > > Basically, we concatenate messages with colons (no period at the end > > either).
Oh, thanks. > On March 29, 2017, 9:09 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/killtree.hpp > > Line 41 (original), 44 (patched) > > <https://reviews.apache.org/r/56367/diff/2/?file=1677263#file1677263line45> > > > > NOTE: For notes, the convention is to format notes like: > > ``` > > // NOTE: Text of thing to note goes here. > > ``` Ah thanks. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56367/#review170449 ----------------------------------------------------------- On March 27, 2017, 10:42 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56367/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 10:42 p.m.) > > > Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park. > > > Bugs: MESOS-6868 > https://issues.apache.org/jira/browse/MESOS-6868 > > > Repository: mesos > > > Description > ------- > > On Windows, a "process tree" is in fact a job object. Thus, the > implementation of `os::killtree` on Windows is a shim which terminates > the job object corresponding to the process group represented by the > given PID. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/killtree.hpp > 2be2f8c3d58ee64410f87ee4a4b2bb54fe014748 > > > Diff: https://reviews.apache.org/r/56367/diff/2/ > > > Testing > ------- > > Testing done at end of chain. > > > Thanks, > > Andrew Schwartzmeyer > >
