----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57912/#review170574 -----------------------------------------------------------
Fix it, then Ship it! src/checks/checker.cpp Lines 370-371 (patched) <https://reviews.apache.org/r/57912/#comment243429> Let's use semicolon here. src/launcher/default_executor.cpp Lines 741-742 (original), 749-750 (patched) <https://reviews.apache.org/r/57912/#comment243431> This comment was different on purpose. I'm not sure that "task is checked" will be read by everyone as "task has a checker associated". I believe that "check" is a too vague term for this. - Alexander Rukletsov On March 29, 2017, 4:40 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57912/ > ----------------------------------------------------------- > > (Updated March 29, 2017, 4:40 p.m.) > > > Review request for mesos, Alexander Rukletsov and Vinod Kone. > > > Bugs: MESOS-7276 > https://issues.apache.org/jira/browse/MESOS-7276 > > > Repository: mesos > > > Description > ------- > > Enabled pause/resume for checks. > > > Diffs > ----- > > src/checks/checker.hpp e8af3160c9fd52ec20acf41b86bade50f4539fb1 > src/checks/checker.cpp 314354cc374b453ec12e25e3d4730a92697468cf > src/launcher/default_executor.cpp 606fd9c164052fe8d168969bbb05f6ec99180d3b > src/launcher/executor.cpp a4bac9d932b6574eb2e1b4a27aa44eaaca6aaa62 > > > Diff: https://reviews.apache.org/r/57912/diff/2/ > > > Testing > ------- > > `make check` on Fedora 24 > > > Thanks, > > Gastón Kleiman > >
