----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58055/#review170670 -----------------------------------------------------------
Fix it, then Ship it! docs/authorization.md Line 61 (original), 61 (patched) <https://reviews.apache.org/r/58055/#comment243556> Not yours, but should this be `[weights](weights.md)`? docs/roles.md Lines 27 (patched) <https://reviews.apache.org/r/58055/#comment243563> `s/one or many/one or more/`? docs/roles.md Line 99 (original), 116 (patched) <https://reviews.apache.org/r/58055/#comment243565> `s/mesos/Mesos/` docs/roles.md Lines 101-102 (original), 118-119 (patched) <https://reviews.apache.org/r/58055/#comment243564> > Frameworks using the `*` role cannot make dynamic reservations. Hm.. is this true? or is it just that the framework can't make dynamic reservations on the resources allocated to the `*` role? docs/scheduler-http-api.md Lines 112 (patched) <https://reviews.apache.org/r/58055/#comment243566> Hm.. what happened here...? it was just missing before? docs/scheduler-http-api.md Line 183 (original), 184 (patched) <https://reviews.apache.org/r/58055/#comment243567> Not yours but the indentation is off here.. docs/scheduler-http-api.md Lines 272 (patched) <https://reviews.apache.org/r/58055/#comment243568> Was this actually supposed to be `"one-of-my-roles"`? or was it supposed to be `<one-of-my-roles>`? docs/scheduler-http-api.md Line 455 (original), 459 (patched) <https://reviews.apache.org/r/58055/#comment243569> re: `s/offer_id/id/`, nice catch! docs/scheduler-http-api.md Lines 459-475 (original), 464-481 (patched) <https://reviews.apache.org/r/58055/#comment243570> Should these be 2-space indented? - Michael Park On March 29, 2017, 6:13 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58055/ > ----------------------------------------------------------- > > (Updated March 29, 2017, 6:13 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-7324 > https://issues.apache.org/jira/browse/MESOS-7324 > > > Repository: mesos > > > Description > ------- > > This also updates the roles documentation to reflect the vision > of roles representing the resource consumer. > > > Diffs > ----- > > docs/authentication.md 1574db981d5f8ddd7d1f6bef1c2b032823d17297 > docs/authorization.md b019120b1dde35d2cd5f613ddc3d6db32715c9ca > docs/persistent-volume.md 410993fb69eb73db6ad17ef361f9b72cba5dc84d > docs/quota.md 931542b37ef398c015e33ca004650b7689e03adf > docs/reservation.md ace5cef4bccb56126a5338ecde04b91c1a90ce58 > docs/roles.md 344a0e375210e5e60e225276b715650dd0934d47 > docs/scheduler-http-api.md 7f808f10a9f71fba44574079238fd6028ff6520c > docs/shared-resources.md 1b490e253447a9e263cb5a6bda10f360ea7138ce > > > Diff: https://reviews.apache.org/r/58055/diff/1/ > > > Testing > ------- > > N/A > > > Thanks, > > Benjamin Mahler > >
