> On March 22, 2017, 2:45 p.m., Till Toenshoff wrote: > > src/slave/flags.cpp > > Lines 152 (patched) > > <https://reviews.apache.org/r/55065/diff/1/?file=1592795#file1592795line152> > > > > We generally use `#ifdef` instead of `#if defined()`. > > > > Seems we could avoid a bit of duplication by only guarding the default > > value by the `ifdef`.
The patch is now reduced to the `flags` width - hence dropping this issue. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55065/#review169708 ----------------------------------------------------------- On March 31, 2017, 8:26 p.m., Ayanampudi Varsha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55065/ > ----------------------------------------------------------- > > (Updated March 31, 2017, 8:26 p.m.) > > > Review request for mesos, Kevin Klues, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-6742 > https://issues.apache.org/jira/browse/MESOS-6742 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/linux/ldcache.cpp 6260496672cd0226a24ea1b34003a48af9678a63 > > > Diff: https://reviews.apache.org/r/55065/diff/2/ > > > Testing > ------- > > make check > make check GTEST_FILTER="LdcacheTest.Parse" > > > Thanks, > > Ayanampudi Varsha > >
