----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58125/#review170802 -----------------------------------------------------------
3rdparty/stout/include/stout/stringify.hpp Lines 42 (patched) <https://reviews.apache.org/r/58125/#comment243680> We've learned, from other projects, that converting from string to/from wstring to/from utf8string can be VERY expensive operations, particularly when unicode is allowed. Certain unicode operations can be extraordinarily slow. Due to this, we learned that we're far better off just storing things in a CONSISTENT format (generally wstring, since that's fast for length operations and such) and then, if we need to convert for final transmission, convert once at the very end. How heavily will this function be used? And, of course, it's in stout, but if stout was better desogmed, it would be nicer to have a separate implementation rather than inlining code in a bunch of places. - Jeff Coffler On March 31, 2017, 11:45 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58125/ > ----------------------------------------------------------- > > (Updated March 31, 2017, 11:45 p.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and > Michael Park. > > > Repository: mesos > > > Description > ------- > > Stout: Added stringify for std::wstring. > > > Diffs > ----- > > 3rdparty/stout/include/stout/stringify.hpp > e9588d8d940046791794100c53469288656a14f0 > > > Diff: https://reviews.apache.org/r/58125/diff/1/ > > > Testing > ------- > > Testing done later in chain. > > > Thanks, > > Andrew Schwartzmeyer > >
