----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57976/#review170938 -----------------------------------------------------------
Ship it! src/launcher/executor.cpp Lines 201-203 (patched) <https://reviews.apache.org/r/57976/#comment243779> This mis-match was carried through from the previous review. - Joseph Wu On March 31, 2017, 4:43 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57976/ > ----------------------------------------------------------- > > (Updated March 31, 2017, 4:43 p.m.) > > > Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park. > > > Repository: mesos > > > Description > ------- > > This commit reverses the file split done in e821978. > Since `launchTaskPosix` and `launchTaskWindows` were reconciled > using `Subprocess`, the files were pulled back into just > `launcher/executor.cpp` with `launchTaskSubprocess`. > > > Diffs > ----- > > src/Makefile.am 071656ad7354a802e8292140a7181cb70b68fe9e > src/launcher/CMakeLists.txt f63f544f92924b92ef41382c40acabef59a56d8b > src/launcher/executor.hpp c7c134aed26d2116295d66100b3d6efaf610736c > src/launcher/executor.cpp bc69beb884d95d1616b2a3d928cdbf00f70f7c88 > src/launcher/posix/executor.hpp 2dd9766aa5b6e0550269ccaa79209d0a483fee76 > src/launcher/posix/executor.cpp 7c4ef10390e7ecfe63e2fd0c813f91c896fc7a8d > > > Diff: https://reviews.apache.org/r/57976/diff/2/ > > > Testing > ------- > > Testing done later in chain. > > > Thanks, > > Andrew Schwartzmeyer > >
