----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58173/#review170975 -----------------------------------------------------------
Patch looks great! Reviews applied: [58173] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 4, 2017, 2:11 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58173/ > ----------------------------------------------------------- > > (Updated April 4, 2017, 2:11 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This patch adds a missing call to `std::move` in the constructor > for `CombinedAuthenticatorProcess` to avoid an unnecessary copy. > > > Diffs > ----- > > src/authentication/http/combined_authenticator.cpp > c734e7672e96087fa715501cfc594a0165f5bce7 > > > Diff: https://reviews.apache.org/r/58173/diff/1/ > > > Testing > ------- > > `make && bin/mesos-tests.sh > --gtest_filter="CombinedAuthenticatorTest.MultipleAuthenticators"` > > > Thanks, > > Greg Mann > >
