> On April 4, 2017, 5:42 p.m., Andrew Schwartzmeyer wrote: > > Ship It!
This patch fixes the `CombinedAuthenticatorTest.MultipleAuthenticators` test failure that otherwise reproduces on Windows 10 with the VS 2017 tools. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58175/#review170995 ----------------------------------------------------------- On April 4, 2017, 2:15 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58175/ > ----------------------------------------------------------- > > (Updated April 4, 2017, 2:15 p.m.) > > > Review request for mesos, Anand Mazumdar, Michael Park, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This patch updates the `loop()` logic within > `CombinedAuthenticatorProcess::authenticate()` to fix a bug > in which an iterator is incremented past the end of its vector. > > > Diffs > ----- > > src/authentication/http/combined_authenticator.cpp > c734e7672e96087fa715501cfc594a0165f5bce7 > > > Diff: https://reviews.apache.org/r/58175/diff/1/ > > > Testing > ------- > > `make && bin/mesos-tests.sh > --gtest_filter="CombinedAuthenticatorTest.MultipleAuthenticators"` > > > Thanks, > > Greg Mann > >
