----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/ -----------------------------------------------------------
Review request for mesos and Mesos Reviewbot. Repository: mesos Description ------- In general, libprocess is unable to validate that a peer is a legitimate owner of the UPID it claims in a libprocess message. This change adds 2 checks that make impersonation somewhat harder. First, we bind the first UPID to the socket context. This prevents a peer attempting to switch UPIDs during a session. Second, we enforce that the IP address in the UPID matches the peer address. This makes spoofing the UPID harder (eg. to send authenticated messages), but also breaks some legitimate configurations, particularly on multihomed hosts. Diffs ----- 3rdparty/libprocess/src/process.cpp d0cba0c2299bddfedeb8bfde5b93aae733a9cd5b Diff: https://reviews.apache.org/r/58224/diff/1/ Testing ------- Minimal manual testing. Thanks, James Peach
