----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58248/#review171303 -----------------------------------------------------------
Ship it! Note: You should consider installing the git-commit hook under `support/hooks/pre-commit`. That will help point out a couple line-length issues and lint your changes on commit. For example, your commit message must be less than 72 characters per line. I can fix up the message for you before committing though. - Joseph Wu On April 6, 2017, 3:16 p.m., Eric Chung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58248/ > ----------------------------------------------------------- > > (Updated April 6, 2017, 3:16 p.m.) > > > Review request for mesos, Joseph Wu and Kevin Klues. > > > Bugs: MESOS-7310 > https://issues.apache.org/jira/browse/MESOS-7310 > > > Repository: mesos > > > Description > ------- > > Related to https://reviews.apache.org/r/58065/, this patch renames lib/mesos > under src/cli_new to lib/cli in preparation for adding the > src/python/lib/mesos module which will separate the mesos python http client > from the cli. > > > Diffs > ----- > > src/cli_new/bin/config.py 274f8c63b0c642637f17aa2e3c8c4a8a5a059e37 > src/cli_new/bin/main.py bbfb52c894540158c70e0f50ebb8a277b692d54d > src/cli_new/lib/mesos/__init__.py > src/cli_new/lib/mesos/docopt.py > src/cli_new/lib/mesos/exceptions.py > src/cli_new/lib/mesos/plugins/__init__.py > src/cli_new/lib/mesos/plugins/base.py > 61b15428b029cec9ec7c9d89ab949959c3dc5b88 > src/cli_new/lib/mesos/util.py 87d2a65e78f04209566c1434b489b941d570ee01 > > > Diff: https://reviews.apache.org/r/58248/diff/1/ > > > Testing > ------- > > 1. bootstrap cli_new > 2. activate virtualenv of cli_new > 3. check that the mesos command is still runable > > > Thanks, > > Eric Chung > >
