----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58279/#review171394 -----------------------------------------------------------
Ship it! Ship It! - Gilbert Song On April 7, 2017, 4:46 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58279/ > ----------------------------------------------------------- > > (Updated April 7, 2017, 4:46 p.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, and Zhitao Li. > > > Bugs: MESOS-7366 > https://issues.apache.org/jira/browse/MESOS-7366 > > > Repository: mesos > > > Description > ------- > > Use MNT_DETACH to unmount persistent volumes in DockerContainerizer to > workaround an issue of incorrect handling of container destroy > failures. Currently, if unmount fails there, the containerizer will > still treat the container as terminated, and the agent will schedule > the cleanup of the container's sandbox. Since the mount hasn't been > removed in the sandbox (e.g., due to EBUSY), that'll result in data in > the persistent volume being incorrectly deleted. Use MNT_DETACH so > that the mount point in the sandbox will be removed immediately. See > MESOS-7366 for more details. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp be1a298b12374bced44e2467cb7e90a1599abb8f > > > Diff: https://reviews.apache.org/r/58279/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
