----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58303/#review171531 -----------------------------------------------------------
Fix it, then Ship it! LGTM, minor nit. src/master/master.cpp Lines 8435-8439 (original), 8435-8436 (patched) <https://reviews.apache.org/r/58303/#comment244478> Nit: I'd probably swap these CHECKs to match the parameter order (or swap the parameters). - Adam B On April 10, 2017, 8:48 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58303/ > ----------------------------------------------------------- > > (Updated April 10, 2017, 8:48 a.m.) > > > Review request for mesos and Mesos Reviewbot. > > > Bugs: MESOS-7372 > https://issues.apache.org/jira/browse/MESOS-7372 > > > Repository: mesos > > > Description > ------- > > In all cases where we call Master::removeTask, we have the correct slave > pointer in hand. We can just pass it down, avoiding the need to look it > up again with the SlaveID. > > > Diffs > ----- > > src/master/master.hpp d537933d0b467a6f9996951c601b31338bb9d034 > src/master/master.cpp c1f3c4f3bbcbfb10ae8fc974bd4a16ec070a79fd > > > Diff: https://reviews.apache.org/r/58303/diff/1/ > > > Testing > ------- > > Make check (Fedora 25). Internal fuzzing. > > > Thanks, > > James Peach > >
