----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58253/#review171542 -----------------------------------------------------------
include/mesos/authorizer/authorizer.proto Lines 57 (patched) <https://reviews.apache.org/r/58253/#comment244485> Good question. I wonder if there's a more generic data structure (not `ContainerInfo`, I guess) that we could use that still includes ContainerID. `ContainerState` looks promising, but I'm not sure if we have all of that when we're trying to authorize. Can you elaborate on what (new) action will use this object type, and how, and from where? - Adam B On April 6, 2017, 8:33 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58253/ > ----------------------------------------------------------- > > (Updated April 6, 2017, 8:33 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod > Kone. > > > Bugs: MESOS-7014 > https://issues.apache.org/jira/browse/MESOS-7014 > > > Repository: mesos > > > Description > ------- > > This patch adds a new member, `container_id` to the > `ObjectApprover::Object` to facilitate implicit executor > authorization. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > 75801ccc753a60ce5e5979b6723fd2294ce7ffe5 > include/mesos/authorizer/authorizer.proto > 736f76d552956f2351ffd40fc51d088dff83f8c8 > src/authorizer/local/authorizer.cpp > e241edf4afa48d35dbbbb94d72e8e8690f5bedfc > > > Diff: https://reviews.apache.org/r/58253/diff/1/ > > > Testing > ------- > > Testing details can be found at the end of this chain. > > > Thanks, > > Greg Mann > >
