> On April 11, 2017, 8:21 a.m., Adam B wrote: > > src/authorizer/local/authorizer.cpp > > Line 458 (original), 405 (patched) > > <https://reviews.apache.org/r/57473/diff/5/?file=1684280#file1684280line467> > > > > Why isn't this a `return Error();` too?
Originally we used the `UNKNOWN` in case someone was using an old authorizer in a newer mesos (without newer actions). In that case we will return false, but I can change that I guess. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/#review171392 ----------------------------------------------------------- On April 11, 2017, 10:48 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57473/ > ----------------------------------------------------------- > > (Updated April 11, 2017, 10:48 a.m.) > > > Review request for mesos, Adam B and Benjamin Bannier. > > > Bugs: MESOS-7026 > https://issues.apache.org/jira/browse/MESOS-7026 > > > Repository: mesos > > > Description > ------- > > Adds mechanisms to support authorization of hierarchical roles, > that is, it allows operators to write ACLs of the form `role/%` > which will enforce the rule for any nested role, e.g. `role/a`, > `role/b` and such. > > > Diffs > ----- > > src/authorizer/local/authorizer.cpp > e241edf4afa48d35dbbbb94d72e8e8690f5bedfc > > > Diff: https://reviews.apache.org/r/57473/diff/6/ > > > Testing > ------- > > `make check` > > > Thanks, > > Alexander Rojas > >
