----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57972/#review171621 -----------------------------------------------------------
src/tests/environment.hpp Lines 31-32 (patched) <https://reviews.apache.org/r/57972/#comment244579> We definitely don't want to use any namespace alias-ing in header files; otherwise the alias will bleed through to other files and lead to all sorts of nastiness :( src/tests/environment.cpp Line 79 (original), 79-80 (patched) <https://reviews.apache.org/r/57972/#comment244583> We usually prefer importing the exact class rather than the whole namespace. - Joseph Wu On April 10, 2017, 2:41 p.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57972/ > ----------------------------------------------------------- > > (Updated April 10, 2017, 2:41 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Bugs: MESOS-6731 > https://issues.apache.org/jira/browse/MESOS-6731 > > > Repository: mesos > > > Description > ------- > > Added base stout Environment class to mesos-tests Environment class. > > > Diffs > ----- > > src/tests/environment.hpp 06b6d54fc76b327e3e26914eb61c16619a36de42 > src/tests/environment.cpp e3cff1847c44bb06bbe898211bfca35cf851217a > src/tests/main.cpp 5d062c3451bdfb5d5fc459ac7c071ab18e6d8043 > > > Diff: https://reviews.apache.org/r/57972/diff/3/ > > > Testing > ------- > > Ran make check on Linux and the tests on Windows. > > > Thanks, > > John Kordich > >
