----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58373/#review171697 -----------------------------------------------------------
LGTM. However, I'm not authz expert. Assuming adding a single HTTP header does the job — you get my shipit. src/checks/checker.cpp Lines 207 (patched) <https://reviews.apache.org/r/58373/#comment244735> Is pass-by-value intended? - Alexander Rukletsov On April 12, 2017, 9:21 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58373/ > ----------------------------------------------------------- > > (Updated April 12, 2017, 9:21 a.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Gastón > Kleiman, and Vinod Kone. > > > Bugs: MESOS-7377 > https://issues.apache.org/jira/browse/MESOS-7377 > > > Repository: mesos > > > Description > ------- > > This patch updates the `Checker` to permit initialization with > an authorization header, which it will provide to the agent > operator API for authentication when present. > > > Diffs > ----- > > src/checks/checker.hpp fb939d85dbec2bf7e81e0c11518ccecddc5a7a11 > src/checks/checker.cpp 7510bf23977e007d101fab635865b7160c3a5af6 > > > Diff: https://reviews.apache.org/r/58373/diff/1/ > > > Testing > ------- > > Testing details can be found at the end of this chain. > > > Thanks, > > Greg Mann > >
