----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58448/#review171981 -----------------------------------------------------------
Please note that this patch was also [submitted to ZooKeeper](https://issues.apache.org/jira/browse/ZOOKEEPER-2756), though it's final form for the upstream project will probably be different (rebased onto master and split into multiple patches). - Andrew Schwartzmeyer On April 14, 2017, 2:15 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58448/ > ----------------------------------------------------------- > > (Updated April 14, 2017, 2:15 a.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Repository: mesos > > > Description > ------- > > This unblocks us from building exclusively with VS 2017. The previous > patch to ZooKeeper only added VS 2015 support. This patch replaces it > with a CMake build system that will generate whichever solution we need > for Windows (and can replace the Autotools system on Linux). > > We're updating to 3.5.2-alpha as the existing 3.5.1 rebundle was a > source tarball, and so missing the necessary generated files. The most > currently used version was based off a random commit. 3.5.2-alpha is the > latest 3.5.x release of ZooKeeper (3.5.x itself is alpha, 3.5.2 is > semi-stable, in comparison to 3.5.3 which is in RC). > > > Diffs > ----- > > 3rdparty/CMakeLists.txt bb61ef0514fb164f35b34bb6be1bbebb4d1a1861 > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake > c60652688a23f8628f133b7890ff39e38fc8ae94 > 3rdparty/cmake/Versions.cmake 912726351ff744dd839b8d1c8d64dcc373d879be > 3rdparty/zookeeper-3.5.2-alpha.patch PRE-CREATION > > > Diff: https://reviews.apache.org/r/58448/diff/1/ > > > Testing > ------- > > cmake and make check on Linux > stout-tests, libprocess-tests, and mesos-tests on Windows (last still > pending, they're so slow). > > Also testing the build on a clean machine with nothing but the VS 2017 build > tools (no IDE, no prior VS installations), results pending. > > > Thanks, > > Andrew Schwartzmeyer > >
