----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58449/#review171985 -----------------------------------------------------------
Patch looks great! Reviews applied: [57898, 58446, 58447, 58448, 58449] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 14, 2017, 2:10 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58449/ > ----------------------------------------------------------- > > (Updated April 14, 2017, 2:10 a.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Repository: mesos > > > Description > ------- > > The `SOURCE_SUBDIR` command to `ExternalProject_Add` was added in CMake > 3.7.0, and is necessary to most cleanly build an external CMake built > project where the `CMakeLists.txt` is in a subfolder of the project. > > > Diffs > ----- > > CMakeLists.txt ea529ec2d5c2b9be4f19c67c2033c3f4b9073c1f > > > Diff: https://reviews.apache.org/r/58449/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
