----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58214/#review172153 -----------------------------------------------------------
Ship it! Ship It! - Michael Park On April 5, 2017, 10:54 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58214/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 10:54 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-7316 > https://issues.apache.org/jira/browse/MESOS-7316 > > > Repository: mesos > > > Description > ------- > > In f441eb9 we in a number of places changed how 'Flag's were added to > 'Flags' by moving from ad-hoc invocations of 'FlagsBase::add' on > particular instances to proper 'Flags' member variables. This was needed > to ensure 'Flags' instances could always safely be copied. For that we > introduced local derived 'Flags' classes to support localized parsing > needs. At the same time, this implementation strategy led to these these > local variables not being accessible through instances of the original > class anymore (this was inevitable when making 'Flags' classes properly > copyable), which e.g., causes a regression in the flags displayed in a > master's '/flags' endpoint. > > This commit moves the flags into the respective base class removing the > local classes so that all passed flags are exposed to users. > > > Diffs > ----- > > src/master/flags.hpp 41a0edf > src/master/flags.cpp d25cfdd > src/master/main.cpp fa7ba13 > src/slave/flags.hpp 2c4bd6a > src/slave/flags.cpp 71935de > src/slave/main.cpp a124d2e > > > Diff: https://reviews.apache.org/r/58214/diff/1/ > > > Testing > ------- > > `make check` (Fedora 25) > > This is a backport to `1.2.x` of the https://reviews.apache.org/r/57994/ > which applied against the then `master` branch (1.3 in spe). > > > Thanks, > > Benjamin Bannier > >
