----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58487/#review172162 -----------------------------------------------------------
Patch looks great! Reviews applied: [58485, 58486, 58487] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 17, 2017, 11:14 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58487/ > ----------------------------------------------------------- > > (Updated April 17, 2017, 11:14 p.m.) > > > Review request for mesos, James Peach and Jiang Yan Xu. > > > Bugs: MESOS-7308 > https://issues.apache.org/jira/browse/MESOS-7308 > > > Repository: mesos > > > Description > ------- > > When shared resources are removed from the `allocations` in the sorter, > we remove the scalar quantity only when the shared resource is actually > removed (i.e. shared count goes down to 0). Similarly, we increase the > scalar quantity only when this is a new shared resource that is being > added to the `allocations`. > > > Diffs > ----- > > src/master/allocator/sorter/drf/sorter.cpp > ed54680cecb637931fc344fbcf8fd3b14cc24295 > > > Diff: https://reviews.apache.org/r/58487/diff/1/ > > > Testing > ------- > > Tests passed. > > > Thanks, > > Anindya Sinha > >
