----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58463/#review172170 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On April 17, 2017, 9:52 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58463/ > ----------------------------------------------------------- > > (Updated April 17, 2017, 9:52 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-6327 > https://issues.apache.org/jira/browse/MESOS-6327 > > > Repository: mesos > > > Description > ------- > > When a layer overwrites a symbolic link with a regular file, the link > must be removed first, otherwise 'cp' would follow the link and > overwrite the target instead of the link itself. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp > 584cc6524f81cc1bc231b105507dbfe51fec991d > > > Diff: https://reviews.apache.org/r/58463/diff/2/ > > > Testing > ------- > > sudo make check > > Manually tested with the following docker images: > https://hub.docker.com/r/anldisr/mesos_layers/ (provided by the reporter) > https://hub.docker.com/r/chhsiao/mycrosslink/ (simplist image to reproduce > the same bug) > > > Thanks, > > Chun-Hung Hsiao > >
