----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58021/#review172176 -----------------------------------------------------------
src/common/protobuf_utils.cpp Lines 435-448 (original), 435-452 (patched) <https://reviews.apache.org/r/58021/#comment245288> why pull those outside the function? Can we still keep them inside injectAllocationInfo? src/common/protobuf_utils.cpp Lines 577-581 (patched) <https://reviews.apache.org/r/58021/#comment245289> Ditto here. - Jie Yu On April 4, 2017, 12:47 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58021/ > ----------------------------------------------------------- > > (Updated April 4, 2017, 12:47 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-7314 > https://issues.apache.org/jira/browse/MESOS-7314 > > > Repository: mesos > > > Description > ------- > > Added storage-related offer operations. > > > Diffs > ----- > > include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac > include/mesos/v1/mesos.proto 228623155c7f68c0f24d173aacbc6eb734f1382f > src/common/protobuf_utils.cpp 3fcaf786b29a00f003c10b0f1614a2c7eddc725d > src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a > src/master/master.cpp 6a6a570e52d21bfb2443f981e3d7faf8c36f74bc > src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11 > > > Diff: https://reviews.apache.org/r/58021/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
