----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58357/#review172226 -----------------------------------------------------------
Thanks for this, Zhitao! Glad to see this script getting some new functionality. :) support/test-upgrade.py Lines 76-85 (patched) <https://reviews.apache.org/r/58357/#comment245329> A high level comment: insteads of parametrizing the framework by "language", perhaps we could parametrize it by something more generic like "framework name". You could use names like "cpp-test-framework", etc. This would make it easier to expand this list to include other test frameworks from the codebase in the future. What do you think? support/test-upgrade.py Lines 164 (patched) <https://reviews.apache.org/r/58357/#comment245331> Perhaps the default should be to run all of the available test frameworks, rather than just one? - Greg Mann On April 12, 2017, 12:02 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58357/ > ----------------------------------------------------------- > > (Updated April 12, 2017, 12:02 a.m.) > > > Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann. > > > Bugs: MESOS-7228 > https://issues.apache.org/jira/browse/MESOS-7228 > > > Repository: mesos > > > Description > ------- > > This patch added support to java and python based test framework in > `test-upgrade.py` script by adding a new option `--lang`. > > > Diffs > ----- > > support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45 > > > Diff: https://reviews.apache.org/r/58357/diff/2/ > > > Testing > ------- > > Ran this on all three languages options for cpp, java and python. > > > Thanks, > > Zhitao Li > >
