> On April 19, 2017, 12:33 a.m., Vinod Kone wrote: > > src/tests/slave_authorization_tests.cpp > > Lines 1070 (patched) > > <https://reviews.apache.org/r/58428/diff/3/?file=1692836#file1692836line1070> > > > > don't need terminate/wait slave here like the above test?
Nope, this test uses `cluster::Slave` instead of a spawned `MockSlave`, so the cleanup is done automatically in the destructor. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58428/#review172293 ----------------------------------------------------------- On April 19, 2017, 6:48 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58428/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 6:48 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-7339 > https://issues.apache.org/jira/browse/MESOS-7339 > > > Repository: mesos > > > Description > ------- > > This patch adds new tests to verify that HTTP executors cannot > subscribe or launch nested containers when HTTP executor > authentication is enabled, authorization is enabled, and they > do not provide a valid executor authentication token > > > Diffs > ----- > > src/tests/slave_authorization_tests.cpp > 3657e0a3d19d75cef92e5bf90b65ef00c291b032 > > > Diff: https://reviews.apache.org/r/58428/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
