----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58533/#review172377 -----------------------------------------------------------
src/tests/sorter_tests.cpp Lines 1547 (patched) <https://reviews.apache.org/r/58533/#comment245489> Should end in a period. Can we also clarify the exact number of clients we expect in each configuration? src/tests/sorter_tests.cpp Lines 1570 (patched) <https://reviews.apache.org/r/58533/#comment245488> I wonder if an iterative solution would be clearer. src/tests/sorter_tests.cpp Lines 1571 (patched) <https://reviews.apache.org/r/58533/#comment245481> Why are we passing `depth` and `breadth` by const ref here? I'd prefer just `size_t` (no const for by-value parameters). - Neil Conway On April 19, 2017, 2:21 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58533/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 2:21 p.m.) > > > Review request for mesos, Benjamin Mahler and Neil Conway. > > > Bugs: MESOS-7395 > https://issues.apache.org/jira/browse/MESOS-7395 > > > Repository: mesos > > > Description > ------- > > This test is very similar to Sorter_BENCHMARK_Test.FullSort, except > that hierarchical role is built instead of flat one. > > > Diffs > ----- > > src/tests/sorter_tests.cpp 43bd85798aef0c89751b725ebf35308a5e9e997a > > > Diff: https://reviews.apache.org/r/58533/diff/1/ > > > Testing > ------- > > `./bin/mesos-tests.sh --benchmark > --gtest_filter="AgentAndClientCount/HSorter_BENCHMARK_Test.FullSort*"` > > > Thanks, > > Jay Guo > >
