----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58545/#review172437 -----------------------------------------------------------
Ship it! LGTM. I'm looking for MultioRole-related TODOs and see what could be resolved now. In the future, I feel labeling TODO seems to be a good practice worth calling out in the dev community. - Jay Guo On April 20, 2017, 6:32 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58545/ > ----------------------------------------------------------- > > (Updated April 20, 2017, 6:32 a.m.) > > > Review request for mesos, Benjamin Bannier and Jay Guo. > > > Bugs: MESOS-7368 > https://issues.apache.org/jira/browse/MESOS-7368 > > > Repository: mesos > > > Description > ------- > > Now that the support for frameworks with multiple roles has been > implemented, we can remove the note about the `FrameworkInfo.roles` > field having an incomplete implementation. > > > Diffs > ----- > > include/mesos/mesos.proto eaa2d2ac697cfc4f5aa56db0fb37363339608f43 > include/mesos/v1/mesos.proto 1a32a7bdc991c77b35a988bf8a34cee936c97608 > > > Diff: https://reviews.apache.org/r/58545/diff/1/ > > > Testing > ------- > > N/A > > > Thanks, > > Benjamin Mahler > >
