----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58196/#review172473 -----------------------------------------------------------
Fix it, then Ship it! src/checks/checker.cpp Lines 1104 (patched) <https://reviews.apache.org/r/58196/#comment245590> I think you're missing a space after "port". - Gastón Kleiman On April 19, 2017, 3:16 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58196/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 3:16 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-7275 > https://issues.apache.org/jira/browse/MESOS-7275 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/checks/checker.hpp fec30a22494c2684377c579b601cac1f4e909608 > src/checks/checker.cpp cf7a086ead4413083ea1e28112f1f22dc18f0a89 > src/launcher/default_executor.cpp d003c1b307c0c258fd82028ea7d932d92653e746 > src/launcher/executor.cpp d14fbfb65d1cc44c954c8cdbbf36d7ddf6ede19e > src/tests/check_tests.cpp 79ba5eb38b6e7338392fb17ad39f6cd250f87d88 > > > Diff: https://reviews.apache.org/r/58196/diff/3/ > > > Testing > ------- > > make check on Mac OS 10.11.6 and various linux variants. > > > Thanks, > > Alexander Rukletsov > >