----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58622/#review172797 -----------------------------------------------------------
Fix it, then Ship it! Can you also add a brief comment to the validation calls in `master.cpp`? src/master/validation.hpp Lines 65 (patched) <https://reviews.apache.org/r/58622/#comment245844> Can we link to a JIRA here? - Neil Conway On April 21, 2017, 5:05 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58622/ > ----------------------------------------------------------- > > (Updated April 21, 2017, 5:05 p.m.) > > > Review request for mesos and Neil Conway. > > > Bugs: MESOS-7372 > https://issues.apache.org/jira/browse/MESOS-7372 > > > Repository: mesos > > > Description > ------- > > Document that master message validation is best effort. > > > Diffs > ----- > > src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e > > > Diff: https://reviews.apache.org/r/58622/diff/1/ > > > Testing > ------- > > None (no code changes). > > > Thanks, > > James Peach > >
