----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58687/#review173005 -----------------------------------------------------------
Fix it, then Ship it! src/master/allocator/sorter/drf/sorter.cpp Lines 151-155 (original) <https://reviews.apache.org/r/58687/#comment246067> Do we still want the CHECKs or some variant of the comment? src/master/allocator/sorter/drf/sorter.cpp Lines 151-156 (original) <https://reviews.apache.org/r/58687/#comment246068> Could we document these new semantics in the sorter interface? - Benjamin Mahler On April 24, 2017, 11:18 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58687/ > ----------------------------------------------------------- > > (Updated April 24, 2017, 11:18 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Neil Conway. > > > Bugs: MESOS-7323 > https://issues.apache.org/jira/browse/MESOS-7323 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 051f749dd5921a322ca930a042c31814616d38f9 > src/master/allocator/sorter/drf/sorter.cpp > ed54680cecb637931fc344fbcf8fd3b14cc24295 > src/tests/sorter_tests.cpp 43bd85798aef0c89751b725ebf35308a5e9e997a > > > Diff: https://reviews.apache.org/r/58687/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
