> On April 26, 2017, 7:05 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 827 (patched) > > <https://reviews.apache.org/r/58640/diff/1/?file=1697732#file1697732line827> > > > > EXPECT_SOME > > Chun-Hung Hsiao wrote: > Should the `ASSERT_SOME` in Line 813 be changed to `EXPECT_SOME` as well? > If it should be then I'll open a new PR for address it and Niel's suggestion.
You'd want `EXPECT_SOME` if you want the test to continue even if the check fails. Offhand I'd think `ASSERT_SOME` is better here. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58640/#review173078 ----------------------------------------------------------- On April 22, 2017, 1:56 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58640/ > ----------------------------------------------------------- > > (Updated April 22, 2017, 1:56 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7280 > https://issues.apache.org/jira/browse/MESOS-7280 > > > Repository: mesos > > > Description > ------- > > Created a non-empty file 'abc' under the agent's work directory, which > is linked by the symlink '/xyz' in the 2nd layer of the testing image. > This file should not be overwritten by the empty file '/xyz' in the 3rd > layer. Please see the following link for more details: > https://hub.docker.com/r/chhsiao/overwrite/ > The testing image is updated in a way that it is compatible to the > previous Overwrite test. > > > Diffs > ----- > > src/tests/containerizer/provisioner_docker_tests.cpp > c26e1f9b093fda66f14e474006d8148c0b9f3245 > > > Diff: https://reviews.apache.org/r/58640/diff/1/ > > > Testing > ------- > > sudo make test > Manually tested on commit bc12a58 to make sure that the 'abc' becomes empty > in the unpatched copy backend. > > > Thanks, > > Chun-Hung Hsiao > >
