> On April 26, 2017, 8:01 p.m., Ilya Pronin wrote: > > We can check if we got a schema 1 manifest by parsing manifest JSON first > > and checking `schemaVersion` field in it as I did here: > > https://reviews.apache.org/r/53850/diff/1#0 Otherwise we may get a cryptic > > error message saying that some fields are missing. What do you think?
Also related to https://reviews.apache.org/r/58725 Maybe we should just land Ilya's scheme 2 support? Gilbert, thouughts? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58747/#review173085 ----------------------------------------------------------- On April 26, 2017, 7:14 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58747/ > ----------------------------------------------------------- > > (Updated April 26, 2017, 7:14 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, and Jie Yu. > > > Bugs: MESOS-7272 > https://issues.apache.org/jira/browse/MESOS-7272 > > > Repository: mesos > > > Description > ------- > > This check was introduced from this patch: > https://reviews.apache.org/r/53848/ > > The check on registry v2 schema 1 is too strict. It does not work > for registries that are older version < 2.3, because the ContentType > header may be something like this "application/json; charset=utf-8". > No schema information is included in the manifest header for old > registries. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 > > > Diff: https://reviews.apache.org/r/58747/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
