> On April 25, 2017, 5:59 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 379 (patched) > > <https://reviews.apache.org/r/58689/diff/1/?file=1698680#file1698680line379> > > > > Hm.. I was looking for a `framework.active = true` in activateFramework > > but seems this was missed?
As we discussed, turns out I didn't need the `active` member. Removed. > On April 25, 2017, 5:59 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 483-485 (original), 487-493 (patched) > > <https://reviews.apache.org/r/58689/diff/1/?file=1698680#file1698680line487> > > > > Per our conversation, this doesn't seem necessary (intuitively addSlave > > shouldn't induce an activation of the framework within a role). > > > > I guess we can just remove the activation code here and that makes it a > > 2 line fix? No need to store the 'active' state anymore either? Yep! Thanks for this. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58689/#review172968 ----------------------------------------------------------- On April 24, 2017, 4:18 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58689/ > ----------------------------------------------------------- > > (Updated April 24, 2017, 4:18 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Neil Conway. > > > Bugs: MESOS-7323 > https://issues.apache.org/jira/browse/MESOS-7323 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > f84b0574ce9a392c9528c87b04b01dbb2053cff7 > src/master/allocator/mesos/hierarchical.cpp > 051f749dd5921a322ca930a042c31814616d38f9 > src/tests/upgrade_tests.cpp b5a28b5161d896dff250b8ad012c8aac91c3f861 > > > Diff: https://reviews.apache.org/r/58689/diff/1/ > > > Testing > ------- > > `make check` and added a test. > > > Thanks, > > Michael Park > >
