----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58708/#review172996 -----------------------------------------------------------
src/master/main.cpp Lines 257-258 (patched) <https://reviews.apache.org/r/58708/#comment246218> Also, we try to get the open and close quotes on the same line when possible, to make it clearer to the reader when we forget to close a quote. Ditto for the other log in the agent. - Benjamin Mahler On April 26, 2017, 5:35 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58708/ > ----------------------------------------------------------- > > (Updated April 26, 2017, 5:35 p.m.) > > > Review request for mesos, Benjamin Mahler and Kapil Arya. > > > Bugs: MESOS-6976 > https://issues.apache.org/jira/browse/MESOS-6976 > > > Repository: mesos > > > Description > ------- > > During startup, we now check that the compiled-in version number of the > master and agent can be parsed by stout's `Version::parse` (i.e., that > `MESOS_VERSION` is valid according to stout's extended variant of the > Semver 2.0.0 format). > > > Diffs > ----- > > src/master/main.cpp 462ed3229d15b157a92d96860503c06368ab21b7 > src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52 > > > Diff: https://reviews.apache.org/r/58708/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
