----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58754/#review173306 -----------------------------------------------------------
Patch looks great! Reviews applied: [58754] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 28, 2017, 2:13 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58754/ > ----------------------------------------------------------- > > (Updated April 28, 2017, 2:13 a.m.) > > > Review request for mesos, Joseph Wu and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Previously, the test `SlaveTest.RestartSlaveRequireExecutorAuthentication` > used the command 'cat' in an attempt to run a long-lived task. However, > this command seems to yield a task that will terminate prematurely in some > testing environments. This patch updates the task to use `sleep 120` instead. > > > Diffs > ----- > > src/tests/slave_tests.cpp 8c97dc6d088708d301dc3ccf90d413fd785b782f > > > Diff: https://reviews.apache.org/r/58754/diff/1/ > > > Testing > ------- > > Run in CI to verify that the test is no longer flaky. > > > Thanks, > > Greg Mann > >
