> On April 26, 2017, 11:16 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/version.hpp > > Lines 66-71 (original), 139-182 (patched) > > <https://reviews.apache.org/r/58707/diff/2/?file=1699828#file1699828line143> > > > > These are made public but I can't see how these would be useful to any > > callers, could we just inline lambdas them in the parse function for now > > until these prove needed by some callers?
I marked these as `private`, but I didn't make them lambdas yet: personally, I find large function bodies containing multiple nested lambdas hard to read (it also makes me think through whether the lambda captures any variables, etc.). Happy to discuss further if you'd prefer lambdas here. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58707/#review172994 ----------------------------------------------------------- On April 26, 2017, 5:35 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58707/ > ----------------------------------------------------------- > > (Updated April 26, 2017, 5:35 p.m.) > > > Review request for mesos, Benjamin Mahler and Kapil Arya. > > > Bugs: MESOS-1987 > https://issues.apache.org/jira/browse/MESOS-1987 > > > Repository: mesos > > > Description > ------- > > Previously, Stout's `Version` abstraction only supported a subset of > Semver: version numbers with three numeric components (an optional > trailing "label" with a leading hyphen was supported but ignored). > > This commit adds support for SemVer 2.0.0, which defines two additional > optional fields: a "prerelease label" and a "build metadata label", > e.g., "1.2.3-alpha.1+foo". Both labels consist of a series of > dot-separated identifiers. > > > Diffs > ----- > > 3rdparty/stout/include/stout/version.hpp > 7717c85b95d29cefe8f19f3cada4b7402d4d446f > 3rdparty/stout/tests/version_tests.cpp > 724ed2292fdd3c5f4c98facf82260078b66a0e97 > > > Diff: https://reviews.apache.org/r/58707/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
