----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58898/#review173624 -----------------------------------------------------------
Patch looks great! Reviews applied: [58898] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 1, 2017, 11:58 p.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58898/ > ----------------------------------------------------------- > > (Updated May 1, 2017, 11:58 p.m.) > > > Review request for mesos, Neil Conway and Jiang Yan Xu. > > > Bugs: MESOS-7215 > https://issues.apache.org/jira/browse/MESOS-7215 > > > Repository: mesos > > > Description > ------- > > Mesos is now sending ShutdownFrameworkMessages to the agent for all > non-partition-aware frameworks (including the ones that are still > registered). This is problematic. The offer from this agent can > still go to the same framework which can then launch new tasks. > The agent then receives tasks of the same framework and ignores > them because it thinks the framework is shutting down. The framework > is not shutting down of course, so from the master and the scheduler's > perspective the task is pending in STAGING forever until the next agent > reregistration, which could happen much later. This commit fixes > the problem by sending a task kill instead of ShutdownFrameworkMessage, > when the agent re-registers after being unreachable, for non-partition > aware framewworks. > > > Diffs > ----- > > src/master/master.cpp 31a7a2fcf905c0c35e80692a69c290d4094deded > src/tests/partition_tests.cpp 4ff428564d1fa6cb96e6f8ec8edc331da88a3eb6 > > > Diff: https://reviews.apache.org/r/58898/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Megha Sharma > >
