----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58928/#review173654 -----------------------------------------------------------
3rdparty/libprocess/src/tests/process_tests.cpp Lines 1770 (patched) <https://reviews.apache.org/r/58928/#comment246672> Rather than making up a number here (99), it seems we should get this from the http::Connection. Have you looked into exposing it? 3rdparty/libprocess/src/tests/test_linkee.cpp Lines 130 (patched) <https://reviews.apache.org/r/58928/#comment246673> Are "missing" and "0.0.0.0" different cases? 3rdparty/libprocess/src/tests/test_linkee.cpp Lines 131-134 (patched) <https://reviews.apache.org/r/58928/#comment246676> Is this useful? It seems like we would need to pick the "right one" for whether we're going to talk locally or remotely? Or? 3rdparty/libprocess/src/tests/test_linkee.cpp Lines 139 (patched) <https://reviews.apache.org/r/58928/#comment246674> Failed to gethostname 3rdparty/libprocess/src/tests/test_linkee.cpp Lines 143-144 (patched) <https://reviews.apache.org/r/58928/#comment246675> Do you know why this returns only 1 IP? Isn't it possible for there to be more than 1? - Benjamin Mahler On May 2, 2017, 6 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58928/ > ----------------------------------------------------------- > > (Updated May 2, 2017, 6 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7401 > https://issues.apache.org/jira/browse/MESOS-7401 > > > Repository: mesos > > > Description > ------- > > Some of the remote process tests were using a UPID with a zero > IP address field. In order to enable subsequent IP address > validation in the libprocess receiver, update these tests to > use a UPID containing the real IP address of the sender. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/process_tests.cpp > bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115 > 3rdparty/libprocess/src/tests/test_linkee.cpp > 921d67695bc0e4d601e9f74fbc625d69bf36ba50 > > > Diff: https://reviews.apache.org/r/58928/diff/1/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > >
