----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58880/#review173680 -----------------------------------------------------------
Make sure to update unversioned mesos.proto as well. include/mesos/v1/mesos.proto Lines 2134 (patched) <https://reviews.apache.org/r/58880/#comment246712> s/is never used/has never been used/ include/mesos/v1/mesos.proto Lines 2135 (patched) <https://reviews.apache.org/r/58880/#comment246713> s/the `Secret::Value` field// include/mesos/v1/mesos.proto Lines 2140-2143 (patched) <https://reviews.apache.org/r/58880/#comment246714> I would rephrase this as follows // Docker config containing credentails to authenticate with docker registry. // // The secret is expected to be in docker config file in JSON format with UTF-8 character encoding. - Vinod Kone On April 30, 2017, 11:23 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58880/ > ----------------------------------------------------------- > > (Updated April 30, 2017, 11:23 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Jie Yu, Kapil Arya, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This is a followup patch for https://reviews.apache.org/r/58775/. > > > Diffs > ----- > > include/mesos/v1/mesos.proto f7c05a82f8265aedc0bd8fd20dd30e21af46e775 > > > Diff: https://reviews.apache.org/r/58880/diff/1/ > > > Testing > ------- > > make > > > Thanks, > > Gilbert Song > >
