> On April 28, 2017, 8:37 p.m., Vinod Kone wrote: > > include/mesos/slave/containerizer.proto > > Line 186 (original), 186 (patched) > > <https://reviews.apache.org/r/58820/diff/2/?file=1703232#file1703232line186> > > > > s/sandbox/sandbox in the host (or is it container?) mount namespace/ ? > > > > also, not clear what "Mesos sandbox" means? do you mean the value of > > 'MESOS_SANDBOX' env variable?
Well, the container can always access its sandbox, regardless whether it shares the host filesystem or not. I'm not sure we should refer to the env variable name here, even though we now indeed set both to the same value (modulo the comment). Jie, what do you think? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58820/#review173378 ----------------------------------------------------------- On May 3, 2017, 4:45 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58820/ > ----------------------------------------------------------- > > (Updated May 3, 2017, 4:45 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > c30b1fc659ee9b3cd343899638ced6408d8b51a2 > src/slave/containerizer/mesos/containerizer.cpp > b58baed64480e22f640a4852537f85922ed382ae > > > Diff: https://reviews.apache.org/r/58820/diff/3/ > > > Testing > ------- > > None: not a functional change. > > > Thanks, > > Alexander Rukletsov > >
