----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58923/#review173859 -----------------------------------------------------------
The terminology in this area of the code confuses me. Do we have a glossary for the different executors, command tasks, etc. somewhere? include/mesos/slave/containerizer.proto Lines 166 (patched) <https://reviews.apache.org/r/58923/#comment246905> +1, or just drop "already". And tell me which non-custom executors do decide to pass their environment on to the tasks. Also, the "Additional environment" confuses me. What is it in addition to? The new `task_environment`? Comment should explain the relationship. include/mesos/slave/containerizer.proto Lines 180-184 (original), 184-191 (patched) <https://reviews.apache.org/r/58923/#comment246909> What's the difference between a `task command` and a `command task`? include/mesos/slave/containerizer.proto Lines 192 (patched) <https://reviews.apache.org/r/58923/#comment246907> What order did you insert this in? I'd say either go numeric and put it at the end, or put it next to `environment` so you can explain the difference. - Adam B On May 2, 2017, 10:28 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58923/ > ----------------------------------------------------------- > > (Updated May 2, 2017, 10:28 a.m.) > > > Review request for mesos, Adam B, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-7429 > https://issues.apache.org/jira/browse/MESOS-7429 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > c30b1fc659ee9b3cd343899638ced6408d8b51a2 > > > Diff: https://reviews.apache.org/r/58923/diff/1/ > > > Testing > ------- > > make check and functional testing on chain end. > > > Thanks, > > Till Toenshoff > >
