----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58967/#review173875 -----------------------------------------------------------
Patch looks great! Reviews applied: [58847, 58262, 58718, 58817, 58818, 58819, 58820, 58263, 58821, 58967] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 3, 2017, 4:46 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58967/ > ----------------------------------------------------------- > > (Updated May 3, 2017, 4:46 p.m.) > > > Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7433 > https://issues.apache.org/jira/browse/MESOS-7433 > > > Repository: mesos > > > Description > ------- > > A DEBUG container's working directory should be set to the parent > task's working directory. For the command executor case, even if > the task itself has a root filesystem, the executor container still > uses the host filesystem, hence > `ContainerLaunchInfo.working_directory`, pointing to the executor's > working directory in the host filesystem, may be different from the > task's working directory in the root filesystem. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > c30b1fc659ee9b3cd343899638ced6408d8b51a2 > src/slave/containerizer/mesos/containerizer.cpp > b58baed64480e22f640a4852537f85922ed382ae > > > Diff: https://reviews.apache.org/r/58967/diff/1/ > > > Testing > ------- > > make check on Mac OS and Fedora 24 > > > Thanks, > > Alexander Rukletsov > >
