----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59001/#review174051 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp Lines 228 (patched) <https://reviews.apache.org/r/59001/#comment247156> <p>This might violate the assumption that there is only one filesystem isolator. Maybe check that 'filesystem/linux' is enabled in the creator of 'volume/image' below?</p> src/slave/containerizer/mesos/isolators/volume/secret.cpp Lines 286 (patched) <https://reviews.apache.org/r/59001/#comment247167> Can we just write the secret to `sandboxSecretPath`? - Chun-Hung Hsiao On May 5, 2017, 10:44 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59001/ > ----------------------------------------------------------- > > (Updated May 5, 2017, 10:44 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7418 > https://issues.apache.org/jira/browse/MESOS-7418 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 > src/slave/containerizer/mesos/containerizer.cpp > b58baed64480e22f640a4852537f85922ed382ae > src/slave/containerizer/mesos/isolators/volume/secret.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/secret.cpp PRE-CREATION > src/tests/containerizer/rootfs.cpp fdfecc65a3fcd19d6a4dfa574320f4d1f2755322 > src/tests/containerizer/volume_secret_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/59001/diff/2/ > > > Testing > ------- > > Added new tests an ran `make check`. > > > Thanks, > > Kapil Arya > >
