----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59038/#review174119 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/tests/hierarchical_allocator_tests.cpp Line 745 (original), 745 (patched) <https://reviews.apache.org/r/59038/#comment247219> nitpik: Maybe change the order of the comment to reflect that the 2 frameworks are added in roles "a/c" and "d/e" respectively followed by adding of the slave. src/tests/hierarchical_allocator_tests.cpp Line 783 (original), 783 (patched) <https://reviews.apache.org/r/59038/#comment247221> nitpik: Similar comment as the previous one. - Anindya Sinha On May 6, 2017, 12:50 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59038/ > ----------------------------------------------------------- > > (Updated May 6, 2017, 12:50 a.m.) > > > Review request for mesos, Anindya Sinha and Michael Park. > > > Bugs: MESOS-7462 > https://issues.apache.org/jira/browse/MESOS-7462 > > > Repository: mesos > > > Description > ------- > > Fixed flakiness in HierarchicalAllocatorTest.NestedRoleDRF. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 33d5c0ea0182e09b3f3f30d20a33d46c23d81697 > > > Diff: https://reviews.apache.org/r/59038/diff/1/ > > > Testing > ------- > > `./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose > --gtest_repeat=1000 --gtest_break_on_failure .` > > > Thanks, > > Neil Conway > >
