> On May 6, 2017, 10:46 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 1333 (patched) > > <https://reviews.apache.org/r/58924/diff/1/?file=1705953#file1705953line1333> > > > > Overwriting task environment variable 'name' from 'old value' to 'new > > value'. > > > > maybe better? > > > > btw, mind fix it at launcher/executor.cpp as well? > > Till Toenshoff wrote: > That would leak secrets right now -- lets avoid that if possible. I > actually got rid of this leakage just recently in the launcher/executor.cpp > as well :)
I see. Gotcha. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58924/#review174126 ----------------------------------------------------------- On May 2, 2017, 10:28 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58924/ > ----------------------------------------------------------- > > (Updated May 2, 2017, 10:28 a.m.) > > > Review request for mesos, Adam B, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-7429 > https://issues.apache.org/jira/browse/MESOS-7429 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > b58baed64480e22f640a4852537f85922ed382ae > > > Diff: https://reviews.apache.org/r/58924/diff/2/ > > > Testing > ------- > > make check and functional testing on chain end. > > > Thanks, > > Till Toenshoff > >
